[Identity] Testing service connections on pipeline #29451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
ckairen,
deyaaeldeen,
jeremymeng,
bterlson,
xirzec,
mpodwysocki,
maorleger,
schaabs and
a team
as code owners
KarishmaGhiya
requested review from
christothes,
pvaneck,
billwert and
ahsonkhan
KarishmaGhiya
force-pushed
the
testpipeline
branch
from
d9a92c2
to
c78dbdf
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
KarishmaGhiya
changed the title
maorleger
approved these changes
Apr 29, 2024
sdk/identity/identity/test/public/node/azurePipelinesServiceConnection.spec.ts
Outdated
Show resolved
Hide resolved
| describe("AzurePipelinesServiceConnectionCredential", function () { | ||
| const scope = "https://vault.azure.net/.default"; | ||
| const tenantId = env.IDENTITY_SP_TENANT_ID || env.AZURE_TENANT_ID!; | ||
| const tenantId = "72f988bf-86f1-41af-91ab-2d7cd011db47"; |
There was a problem hiding this comment.
when we record these tests, you'd want any env. calls to be made after the recorder is initialized (so like in the test body or a beforeEach block after creating the recorder. Just FYI. I could be wrong but I remember this being a problem for me
There was a problem hiding this comment.
True. Though with this particular test, it's difficult to have recordings, since I cannot run locally :(
…nnection.spec.ts Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response = {"$id":"1","innerException":null,"message":"The requested version "7.1" of the resource is under preview. The -preview flag must be supplied in the api-version for such requests. For example: "7.1-preview"","typeName":"Microsoft.VisualStudio.Services.WebApi.VssInvalidPreviewVersionException, Microsoft.VisualStudio.Services.WebApi","typeKey":"VssInvalidPreviewVersionException","errorCode":0,"eventId":3000}