Fix/js signoff pipeline #29442
Open
Fix/js signoff pipeline #29442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2024 04:47
…ure-sdk-for-js into fix/js-signoff-pipeline
aditishree1
requested review from
kushagraThapar,
kirankumarkolli,
simorenoh and
v1k1
as code owners
|
API change check API changes are not detected in this pull request. |
sajeetharan
approved these changes
Apr 26, 2024
topshot99
reviewed
Apr 29, 2024
| @@ -51,7 +51,7 @@ function encodeNumberAsUInt64JSBI(value: number): JSBI { | |||
| const rawValueBits = getRawBitsJSBI(value); | |||
| const mask = JSBI.BigInt(0x8000000000000000); | |||
| const returned = | |||
| rawValueBits < mask | |||
| JSBI.toNumber(rawValueBits) < JSBI.toNumber(mask) | |||
There was a problem hiding this comment.
We might lose precision here. is it ok?
There was a problem hiding this comment.
will correct this. we can use JSBI.greaterThan() instead.
|
@aditishree1 Please add details about these changes in the PR "Describe the problem that is addressed by this PR" section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
Describe the problem that is addressed by this PR
This PR fixes the failed tests by mainly addressing following issues:
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists