[OpenAI] Support Top Logprob in Chat Completions #29432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
minhanh-phan
requested review from
bterlson,
xirzec,
jeremymeng,
mpodwysocki,
glharper and
deyaaeldeen
as code owners
deyaaeldeen
approved these changes
Apr 29, 2024
Comment on lines
+240
to
+245
| logprobs?: boolean; | ||
| /** | ||
| * An integer between 0 and 5 specifying the number of most likely tokens to return at each token position, | ||
| * each with an associated log probability. `logprobs` must be set to `true` if this parameter is used. | ||
| */ | ||
| topLogprobs?: number; |
There was a problem hiding this comment.
I wonder do we need two knobs to control this feature? can't we just do with topLogprobs? Perhaps it is more of a question to the architects.
There was a problem hiding this comment.
This is a pattern in OpenAI API, so seems like most languages are surfacing the pattern. In .NET, they rename logprobs as EnableLogProbabilities and topLogprobs as LogProbabilitiesPerToken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/openai
Issues associated with this PR
#29199
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists