Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-tool] react to NodeJS spawn security fix #29414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[dev-tool] react to NodeJS spawn security fix #29414

wants to merge 2 commits into from

Commits on Apr 23, 2024

  1. [dev-tool] react to NodeJS spawn security fix 

    Node made a breaking change in a security release for 18/20 where `spawn()` no
longer loads `.cmd` files by default. nodejs/node#52554.

This PR adds the `shell: true` option to execute command in shell.
    @jeremymeng
    jeremymeng committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0f4355a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Scope to vendored command on Windows. 

    revert other changes as they are not affected.
    @jeremymeng
    jeremymeng committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b438f2f View commit details
    Browse the repository at this point in the history