[Test][core] inline build:test commands into browser test scripts #29411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
jeremymeng
commented
Apr 23, 2024
jeremymeng
commented
Apr 23, 2024
| @@ -57,7 +57,7 @@ | |||
| ], | |||
| "scripts": { | |||
| "build:samples": "echo Obsolete", | |||
| "build:test": "npm run clean && tshy && dev-tool run build-test", | |||
| "build:test": "echo skipped. actual commands inlined in browser test scripts", | |||
There was a problem hiding this comment.
another approach is to have build:test:node and build:test:browser but it seems that we used to have that but moved away from it.
As far as I know for the majority of our packages we don't need to run `build:test` as we either runs test on .ts files, or `build` script already generates the .js files under `dist-esm`. Currently we only need to build the test for browser testing. This PR moves commands in `build:test` into the browser test scripts, thus saving us from rebuilding when testing for NodeJS.
jeremymeng
force-pushed
the
test/core-only-build-test-for-browser
branch
from
efb1f38
to
fcec45d
Compare
jeremymeng
requested review from
HarshaNalluru,
timovv,
ckairen,
mikeharder,
weshaggard,
benbp,
maorleger,
mpodwysocki,
deyaaeldeen,
joheredi and
xirzec
as code owners
xirzec
approved these changes
May 2, 2024
yeah that's what I eventually want too. I had a failed attempt earlier because some packages still depends on build:test. Once we get them to all "echo skipped" then the steps can be removed. |
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
May 8, 2024
for non-core packages in js - core pipelines. This PR is a follow-up of PR Azure#29411 for non-core packages.
jeremymeng
added a commit
that referenced
this pull request
May 10, 2024
for non-core packages in js - core pipelines. This PR is a follow-up of PR #29411 for non-core packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know for NodeJS the majority of our packages don't need
build:testas we either runs test on .ts files, orbuildscript already generates the .js files underdist-esm. Currently we only need to build the test for browser testing.This PR moves commands in
build:testinto the browser test scripts for core packages, thus saving us from rebuilding when testing for NodeJS.