Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JDBC to authenticate with azure identity token credentials #30740

Merged
merged 117 commits into from Sep 2, 2022
Merged

Support JDBC to authenticate with azure identity token credentials #30740

merged 117 commits into from Sep 2, 2022

Conversation

backwind1233
Copy link
Contributor

Description

Support Azure hosted PostgreSQL and MySQL services authenticating with Azure AD.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Feature Checklist

  • In JdbcPropertiesBeanPostProcessor, check if users use Azure managed MySql or PostgreSql with password, if so, add a log to remind users use credential-free features.
  • 5 new artifacts libraries
    • azure-identity-providers-core
    • azure-identity-providers-jdbc-mysql
    • azure-identity-providers-jdbc-postgresql
    • spring-cloud-azure-starter-jdbc-mysql
    • spring-cloud-azure-starter-jdbc-postgresql

Related issues:

backwind1233 and others added 30 commits June 30, 2022 17:05
@backwind1233
initialize jdbc credential free code
ade4049
@backwind1233
- Add jdbc plugin for mysql and postgresql
c0de193 
- Add test cases
@backwind1233
replace AzureJdbcEnvironmentPostProcessor with JDBCPropertiesBeanPost…
bab7088 
…Processor
@backwind1233
renaming:
6e2d2a3 
AzureMySqlMSIAuthenticationPlugin to AzureIdentityMysqlAuthenticationPlugin
AzurePostgresqlMSIAuthenticationPlugin to AzureIdentityPostgresqlAuthenticationPlugin
@backwind1233
format code
7528ea5
@backwind1233
Merge branch 'jdbc-credential-free-gzh' into jdbc-credential-free-gzh…
b4b5577 
…-postprocessor
@backwind1233
poc of CachedTokenCredential
93ab1ac
@backwind1233
add option for cache
78fbe23
@backwind1233
convertPropertySetToAzureProperties
f9282b7
@backwind1233
remove AzureTokenCredentialResolver
8fd21e6
@backwind1233
remove spring dependency in jdbc plugin
2bbe5dc
@backwind1233
remove AzureJDBCProperties
dffdeb0
@backwind1233
by default, tokenCredential use TokenCredential
860a2e2
@backwind1233
code refactor
403e4bc
@backwind1233
rename packages
0e0d0f3
@backwind1233
address issue comments
9d725ad
@backwind1233
address more issue comments
7d70a38
@backwind1233
refactor code
7ad763c
@backwind1233
bugfix and refactor
cb11b8d
@backwind1233
Add cache support for SpringTokenCredentialProvider
840d377
@backwind1233
add condition for SpringTokenCredentialProvider
bc35f6e
@backwind1233
bugfix: tenantId only configured in global properties
e6905a5
@backwind1233
Merge branch 'release/spring-cloud-azure-4.4.0' into jdbc-credential-…
164af78 
…free-gzh-postprocessor
@backwind1233
Address pr issues
febcde8
@backwind1233
Address PR comments
c1fc2c2
@backwind1233
add copyright
767c7a5
@backwind1233
address mvn issue in ClassUtil
940a58e
@yiliuTo
Modify sources of Kafka binder context for Azure Identity support (#3…
60876c8 
…0254)
@backwind1233
Address pr comments and checkstyle issues.
9ab6082
@backwind1233
address maven warnings
155a2c5 
add copyright
@moarychan moarychan added this to the 2022-09 milestone Sep 2, 2022
@saragluna
Copy link
Member

CI failed for The process '/opt/hostedtoolcache/Python/3.6.15/x64/bin/python' failed with exit code 1, but the code doesn't cause it. So skip the check and merge this PR now.

@saragluna saragluna merged commit 54edf86 into Azure:release/spring-cloud-azure-4.4.0-beta.1 Sep 2, 2022
This was referenced Sep 6, 2022
Closed
Closed
Closed
@backwind1233
Copy link
Contributor Author

CI failed for The process '/opt/hostedtoolcache/Python/3.6.15/x64/bin/python' failed with exit code 1, but the code doesn't cause it. So skip the check and merge this PR now.

@saragluna Fixed in this PR.

@backwind1233
Copy link
Contributor Author

Pull request follow-ups:

#30806
#30788
#30772

saragluna pushed a commit to saragluna/azure-sdk-for-java that referenced this pull request Sep 21, 2022
@backwind1233 @saragluna
Support JDBC to authenticate with azure identity token credentials (A…
53ddf33 
…zure#30740)
saragluna added a commit that referenced this pull request Sep 22, 2022
@saragluna @backwind1233
Cherry pick passwordless to the feature/spring-cloud-azure-passwordle…
1e3ae3e 
…ss branch (#31076)

* Support JDBC to authenticate with azure identity token credentials (#30740)
* fix pipeline error (#30806)
* Add UA for mysql and postgresql (#30772)
* add user agent for MySQL and PostgreSQL
* refactor test cases
* Update terminology from credentialfree to passwordless. (#30788)
* Change terminology from credentialfree to passwordless
Co-authored-by: Xiaolu Dai <xiada@microsoft.com>

* Update pom in spring-cloud-azure-starter-jdbc-* (#30993)
* update pom
* add prefix
* Add IT for passwordless feature with Azure MySQL (#30982)
* add some comments
* remove unnecessary changes and fix pipeline bug

Co-authored-by: zhihaoguo <zhihaoguo@microsoft.com>
saragluna added a commit that referenced this pull request Sep 23, 2022
@saragluna @backwind1233
Cherry pick passwordless to the feature/spring-cloud-azure-passwordle…
6c89602 
…ss branch (#31076)

* Support JDBC to authenticate with azure identity token credentials (#30740)
* fix pipeline error (#30806)
* Add UA for mysql and postgresql (#30772)
* add user agent for MySQL and PostgreSQL
* refactor test cases
* Update terminology from credentialfree to passwordless. (#30788)
* Change terminology from credentialfree to passwordless
Co-authored-by: Xiaolu Dai <xiada@microsoft.com>

* Update pom in spring-cloud-azure-starter-jdbc-* (#30993)
* update pom
* add prefix
* Add IT for passwordless feature with Azure MySQL (#30982)
* add some comments
* remove unnecessary changes and fix pipeline bug

Co-authored-by: zhihaoguo <zhihaoguo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@hallipr hallipr Awaiting requested review from hallipr

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@samvaity samvaity Awaiting requested review from samvaity

@g2vinay g2vinay Awaiting requested review from g2vinay

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan

@srnagar srnagar Awaiting requested review from srnagar

@mssfang mssfang Awaiting requested review from mssfang

@joshfree joshfree Awaiting requested review from joshfree

@anuchandy anuchandy Awaiting requested review from anuchandy

@conniey conniey Awaiting requested review from conniey

@lmolkova lmolkova Awaiting requested review from lmolkova

Assignees

@backwind1233 backwind1233

Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
2022-09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@backwind1233 @azure-sdk @saragluna @moarychan @yiliuTo