Skip to content

Commit

Permalink
revert
Browse files Browse the repository at this point in the history
  • Loading branch information
samvaity committed May 9, 2024
1 parent 974c702 commit 4f96094
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 15 deletions.
2 changes: 1 addition & 1 deletion sdk/core/azure-core-test/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/core/azure-core-test",
"Tag": "java/core/azure-core-test_48fa0c3d54"
"Tag": "java/core/azure-core-test_6c6629f320"
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public TestProxyTestBase() {
public static void setupTestProxy() {
testMode = initializeTestMode();
if (isTestProxyEnabled() && (testMode == TestMode.PLAYBACK || testMode == TestMode.RECORD)) {
TestProxyManager.startProxy();
TestProxyManager.startProxy();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,10 @@ public HttpResponse sendSync(HttpRequest request, Context context) {
*/
public void addProxySanitization(List<TestProxySanitizer> sanitizers) {
if (isPlayingBack()) {
sanitizers.forEach(sanitizer -> {
HttpRequest request = createAddSanitizersRequest(List.of(sanitizer), proxyUrl).setHeader(X_RECORDING_ID, xRecordingId);
client.sendSync(request, Context.NONE).close();
});
HttpRequest request
= createAddSanitizersRequest(sanitizers, proxyUrl).setHeader(X_RECORDING_ID, xRecordingId);

client.sendSync(request, Context.NONE).close();
} else {
this.sanitizers.addAll(sanitizers);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,10 @@ public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineN
*/
public void addProxySanitization(List<TestProxySanitizer> sanitizers) {
if (isRecording()) {
sanitizers.forEach(sanitizer -> {
HttpRequest request = createAddSanitizersRequest(List.of(sanitizer), proxyUrl).setHeader(X_RECORDING_ID, xRecordingId);
client.sendSync(request, Context.NONE).close();
});
// HttpRequest request
// = createAddSanitizersRequest(sanitizers, proxyUrl).setHeader(X_RECORDING_ID, xRecordingId);
//
// client.sendSync(request, Context.NONE).close();
HttpRequest request
= createAddSanitizersRequest(sanitizers, proxyUrl).setHeader(X_RECORDING_ID, xRecordingId);

client.sendSync(request, Context.NONE).close();
} else {
this.sanitizers.addAll(sanitizers);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public void testRecordWithRedaction() {
assertEquals(REDACTED, record.getHeaders().get("Ocp-Apim-Subscription-Key"));
assertTrue(record.getResponseHeaders()
.get("Operation-Location")
.startsWith("https://REDACTED"));
.startsWith("https://REDACTED/fr/models//905a58f9-131e-42b8-8410-493ab1517d62"));
// custom sanitizers
assertEquals(REDACTED, record.getResponse().get("modelId"));
assertEquals(REDACTED, record.getResponse().get("client_secret"));
Expand Down

0 comments on commit 4f96094

Please sign in to comment.