Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 8119 #22762

Closed

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8119 See eng/common workflow

@azure-sdk azure-sdk requested a review from scbedd April 17, 2024 23:24
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Apr 17, 2024
@azure-sdk azure-sdk force-pushed the sync-eng/common-publish-common-sanitizers-8119 branch from a089598 to 83d0636 Compare April 19, 2024 22:01
@RickWinter
Copy link
Member

@benbp , @chlowell This looks to be due to sanitization changes. Is EngSys addressing or should this be looked at by Renhe's team?

"invalid polling URL Sanitized"

@benbp
Copy link
Member

benbp commented Apr 22, 2024

@RickWinter we suspect it's related to new sanitization changes made in go by @chlowell. CC @scbedd

@chlowell
Copy link
Contributor

It's because the updated proxy applies its default sanitizers during playback, not just in recording as we've done until now (and as I did in #22745). Applying sanitizers to playback breaks tests in ~80 modules; I'm working to fix the easy ones and skip the rest.

@azure-sdk azure-sdk force-pushed the sync-eng/common-publish-common-sanitizers-8119 branch 4 times, most recently from 1f662d5 to a61f7c6 Compare April 24, 2024 17:08
@azure-sdk azure-sdk force-pushed the sync-eng/common-publish-common-sanitizers-8119 branch 2 times, most recently from 2389fc0 to 9e42bf2 Compare April 26, 2024 00:37
@azure-sdk azure-sdk force-pushed the sync-eng/common-publish-common-sanitizers-8119 branch from 9e42bf2 to 929ac84 Compare April 26, 2024 18:09
@scbedd
Copy link
Member

scbedd commented May 8, 2024

It's because the updated proxy applies its default sanitizers during playback, not just in recording as we've done until now (and as I did in #22745). Applying sanitizers to playback breaks tests in ~80 modules; I'm working to fix the easy ones and skip the rest.

With the internal update, you can work at your own pace with an update to eng/target_proxy_version.txt. Closing this PR. Once everyone has gotten the proxy with common sanitizers working, I'll bump universally and delete the override file.

@scbedd scbedd closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants