Refactored if statement tests to table tests to increase readability …

[griffinbird]

…and maintainability.

• [ X] The purpose of this PR is explained in this or a referenced issue.
• [ X] The PR does not update generated files.
  • These files are managed by the codegen framework at Azure/autorest.go.
• [ X] Tests are included and/or updated for code changes.
• Updates to module CHANGELOG.md are included.
• [ X] MIT license headers are included in each file.

[RickWinter]

@lirenhe can you analyze and determine if you want to take this change. Currently it is failing various pipelines so it needs work before it can be accepted

[ealsur]

I personally find this refactoring a bit less clear than the ifs. Having to understand the usage of t.Run with the delegate seems a bit more complicated than understanding a list of if conditions.

But I would see value if these ifs are unbounded/can keep growing, so it would reduce the volume of code required. But the reality is that these properties will not really change frequently so the chances of a developer having to keep adding checks here is very low to offset the increase in reading complexity.

Finally, the same pattern (ifs) are used throughout the other files. If we want to think a common pattern, I guess we would need to refactor all the other files too?

[lirenhe]

@lirenhe can you analyze and determine if you want to take this change. Currently it is failing various pipelines so it needs work before it can be accepted

@RickWinter, could you help to provide more context about its impact? Is there any pipelines in mgmt. SDK that also need this change?