Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SAS Version #19299

Merged

Conversation

siminsavani-msft
Copy link
Member

@siminsavani-msft siminsavani-msft commented Oct 6, 2022

Updating the SAS Version won't affect any other string-to-string algorithms and is needed for UserDelegationSAS
(Fixes #19249)

  • fixing comments to UDC file and test
  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Oct 6, 2022
@jhendrixMSFT
Copy link
Member

Be sure to add an entry to the changelog.

jhendrixMSFT
jhendrixMSFT previously approved these changes Oct 6, 2022
@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Oct 6, 2022

Could you also please update azcore to v1.1.4 and add an entry to the changelog in the "other" section? This resolves an issue with incorrect path joining.

@jhendrixMSFT jhendrixMSFT merged commit 46e8351 into Azure:main Oct 6, 2022
@siminsavani-msft siminsavani-msft deleted the siminsavani/update-sas-version branch October 6, 2022 21:45
@siminsavani-msft siminsavani-msft added this to the azblob v0.5.1 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob user delegation SAS wrong service version
2 participants