Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing StorageError typo #19182

Merged
merged 2 commits into from Sep 23, 2022
Merged

Fixing StorageError typo #19182

merged 2 commits into from Sep 23, 2022

Conversation

siminsavani-msft
Copy link
Member

Fixing #18767

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Sep 21, 2022
jhendrixMSFT
jhendrixMSFT requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is in generated code you'll need to add a directive to autorest.md to fix the name else the changes will be long when regenerating.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/storage/azblob/internal/generated/autorest.md

@siminsavani-msft siminsavani-msft merged commit 425f9f6 into Azure:main Sep 23, 2022
@siminsavani-msft siminsavani-msft deleted the siminsavani/fix-typo-error branch September 23, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@tasherif-msft tasherif-msft tasherif-msft approved these changes

@zezha-msft zezha-msft Awaiting requested review from zezha-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siminsavani-msft @jhendrixMSFT @tasherif-msft