Include Integration tests in code coverage #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon and
chlafreniere
as code owners
chlafreniere
reviewed
Nov 4, 2021
| <DataCollectors> | ||
| <DataCollector friendlyName="Code Coverage"> | ||
| <Configuration> | ||
| <SplitCoverage>True</SplitCoverage> |
There was a problem hiding this comment.
what does SplitCoverage mean?
There was a problem hiding this comment.
SplitCoverage is so that we can see the Code Coverage tab in ADO.
More details from this comment here: microsoft/vstest#981 (comment)
| @@ -6,7 +6,12 @@ parameters: | |||
|
|
|||
| steps: | |||
| - task: UseDotNet@2 | |||
| displayName: 'Install .NET Core SDK 3.1.x for Build' | |||
| displayName: 'Install .NET Core SDK 5.0.x for Build' | |||
There was a problem hiding this comment.
are we really using this for the build? Or just for running the tests?
There was a problem hiding this comment.
Should be for tests - the Microsoft.NET.Test.Sdk v17 did not work with .NET Core SDK v3.1
Charles-Gagnon
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #141
Successful run in pipeline: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=127471&view=codecoverage-tab