Query: Fixes stack overflow in SkipEmptyPageQueryPipelineStage #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
leminh98 and
sboshra
as code owners
j82w
approved these changes
Nov 3, 2021
j82w
changed the title
ealsur
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of SkipEmptyPageQueryPipelineStage.MoveNextAsync recursively calls itself if the previous pipeline stage emits an empty page. This leads to stack overflow if there are too many empty pages or if an inner pipeline stage throws from a deeply nested stack. This change refactors the implementation to be iterative rather than recursive and adds unit tests for SkipEmptyPageQueryPipelineStage which previously had none.
Type of change
Closing issues
To automatically close an issue: closes #IssueNumber