Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Remove pypiwin32 and bump pywin32 to 300 #18012

Merged
merged 1 commit into from May 11, 2021
Merged

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented May 8, 2021

Description

Remove pypiwin32

pypiwin32 is already deprecated: https://pypi.org/project/pypiwin32

Per the source code setup.py of pypiwin32:

https://files.pythonhosted.org/packages/13/e8/4f38eb30c4dae36634a53c5b2cd73b517ea3607e10d00f61f2494449cec0/pypiwin32-223.tar.gz

from setuptools import setup

setup(
    name='pypiwin32',
    version='223',
    install_requires='pywin32>=223',
)

It simply installs pywin32>=223, which is already in requirements.py3.windows.txt, so we should remove it.

Bump pywin32 to 300

pywin32 300 follows PEP 440 to import DLLs (mhammond/pywin32#1651) which is a nice change. Hopefully this can resolve #17986.

@yonzhan
Copy link
Collaborator

yonzhan commented May 8, 2021

Packaging

@yonzhan yonzhan added this to the S187 milestone May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLL load failed while importing win32file: The specified module could not be found.
3 participants