Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross RP parent-child dependency #505

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 24, 2024

In #455, the armid package is updated to include the change magodo/armid@7d1b8af, which requires adoption in aztfexport to keep the cross rp parent-child dependencies.

E.g.

Before #455, and with this RP. We can get below when exporting a RG contains ACR:

resource "azurerm_container_registry" "res-1" {
  #...
  depends_on = [
    azurerm_resource_group.res-0,
  ]
}

But since #455 without this RP, we won't get the above depends_on.

@magodo magodo added the bug Something isn't working label Feb 24, 2024
Copy link
Contributor

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magodo magodo merged commit d2f4390 into Azure:main Feb 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants