[experiment2][dpg] do not convert enum client parameters into string #4468
Conversation
archerzz
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
| @@ -498,7 +498,8 @@ public static bool IsIgnoredHeaderParameter(InputParameter operationParameter) | |||
|
|
|||
| private Parameter BuildParameter(in InputParameter operationParameter, Type? typeOverride = null) | |||
| { | |||
| CSharpType type = typeOverride != null ? new CSharpType(typeOverride, operationParameter.Type.IsNullable) : _typeFactory.CreateType(operationParameter.Type); | |||
| CSharpType type = typeOverride != null ? new CSharpType(typeOverride, operationParameter.Type.IsNullable) : | |||
| operationParameter is { IsApiVersion: true, Type: InputEnumType enumType } ? _typeFactory.CreateType(enumType.EnumValueType) : _typeFactory.CreateType(operationParameter.Type); | |||
There was a problem hiding this comment.
Special handling of apiVersion
| @@ -132,6 +133,9 @@ private ClientFields(IEnumerable<Parameter> parameters, InputAuth? authorization | |||
| public FieldDeclaration? GetFieldByParameter(Parameter parameter) | |||
| => GetFieldByParameter(parameter.Name, parameter.Type); | |||
|
|
|||
| public FieldDeclaration? GetFieldByName(string name) | |||
There was a problem hiding this comment.
Provide this method for cases when we don't check type matching. I cannot remove GetFieldByPrarameter, since in some cases we still need to check the type. For example, NamesConflict test project provide a case when client parameter and query parameter have the same name. We actually rely on the type check to decide which should be used. Not sure if that's the best way to do.
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
Hi @archerzz. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Description
Instead of checking the enum value type against protocol parameter type, we just not check types when building operation chain.
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?