-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flag to use kubelogin in non-admin user scenario and updated readme to reflect changes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverMKing
reviewed
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update action.yml
tbarnes94
changed the title
Added flag for non-admin-user.
Added flag to use kubelogin in non-admin user scenarios and updated readme to reflect changes
May 17, 2022
tbarnes94
changed the title
Added flag to use kubelogin in non-admin user scenarios and updated readme to reflect changes
Added flag to use kubelogin in non-admin user scenario and updated readme to reflect changes
May 17, 2022
Still need to update action.yml |
OliverMKing
reviewed
May 17, 2022
OliverMKing
reviewed
May 18, 2022
OliverMKing
approved these changes
May 18, 2022
davidgamero
approved these changes
May 18, 2022
OliverMKing
added a commit
that referenced
this pull request
Jun 7, 2022
* swap to index.js (#51) * Fail on error (#53) * fix index * fix unit tests * add subscription and admin commands (#57) * Bump minimist from 1.2.5 to 1.2.6 (#59) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ansi-regex from 4.1.0 to 4.1.1 (#60) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added flag to use kubelogin in non-admin user scenario and updated readme to reflect changes (#62) Added flag to use kubelogin in non-admin user scenario and updated readme to reflect changes (#62) * Add node modules and compiled JavaScript from main Co-authored-by: Oliver King <oking3@uncc.edu> Co-authored-by: Oliver King <kingoliver@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com>
OliverMKing
added a commit
that referenced
this pull request
Jun 16, 2022
* swap to index.js (#51) * Fail on error (#53) * fix index * fix unit tests * add subscription and admin commands (#57) * Bump minimist from 1.2.5 to 1.2.6 (#59) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ansi-regex from 4.1.0 to 4.1.1 (#60) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added flag to use kubelogin in non-admin user scenario and updated readme to reflect changes (#62) Added flag to use kubelogin in non-admin user scenario and updated readme to reflect changes (#62) * Update README to major version (#65) * export prior to converting kubeconfig (#67) * Add node modules and compiled JavaScript from main Co-authored-by: Oliver King <oking3@uncc.edu> Co-authored-by: Oliver King <kingoliver@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com> Co-authored-by: David Gamero <david340804@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to: #25