Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Update README.md to clarify Sept eol #1434

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Update README.md to clarify Sept eol #1434

merged 3 commits into from
Jun 15, 2023

Conversation

sozercan
Copy link
Member

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable). See test standard for more details.
  • ran make precommit

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@sozercan sozercan requested a review from aramase June 15, 2023 18:19
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1434 (c8c5056) into master (6dc82f9) will decrease coverage by 0.45%.
The diff coverage is 29.77%.

❗ Current head c8c5056 differs from pull request most recent head f8090f0. Consider uploading reports for the commit f8090f0 to get more accurate results

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   36.29%   35.85%   -0.45%     
==========================================
  Files          27       32       +5     
  Lines        2915     4435    +1520     
==========================================
+ Hits         1058     1590     +532     
- Misses       1778     2761     +983     
- Partials       79       84       +5     
Impacted Files Coverage Δ
...adpodidentity/aadpodidentity_deepcopy_generated.go 0.00% <ø> (ø)
...odidentity/v1/aadpodidentity_deepcopy_generated.go 0.00% <ø> (ø)
pkg/apis/aadpodidentity/v1/register.go 0.00% <0.00%> (ø)
pkg/cloudprovider/vm.go 27.89% <0.00%> (+2.20%) ⬆️
pkg/cloudprovider/vmss.go 21.33% <0.00%> (+2.24%) ⬆️
pkg/crd/crd.go 0.99% <0.00%> (+0.32%) ⬆️
pkg/k8s/client.go 5.06% <0.00%> (+1.25%) ⬆️
pkg/k8s/fake.go 0.00% <0.00%> (ø)
pkg/log/options.go 23.80% <0.00%> (-1.20%) ⬇️
pkg/nmi/managed.go 31.25% <0.00%> (+5.44%) ⬆️
... and 10 more

... and 12 files with indirect coverage changes

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the website with the same text?

@sozercan sozercan merged commit 69befdf into master Jun 15, 2023
4 checks passed
@sozercan sozercan deleted the sozercan-patch-1 branch June 15, 2023 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants