Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to keytar to fix builds against node 12+. #2179

Closed
wants to merge 1 commit into from

Conversation

paterasMSFT
Copy link
Contributor

Node 12+ has a breaking change with keytar 4.4.1. 4.5.0 fixes this issue..

@paterasMSFT paterasMSFT changed the title Minor update to ketar to fix builds against node 12+. Minor update to keytar to fix builds against node 12+. May 12, 2020
@dpwatrous
Copy link
Contributor

@bgklein @cRui861 either of you know what's going on with that build failure? Looks like a permissions issue.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@197793d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2179   +/-   ##
=========================================
  Coverage          ?   65.13%           
=========================================
  Files             ?      899           
  Lines             ?    25718           
  Branches          ?     5077           
=========================================
  Hits              ?    16751           
  Misses            ?     8967           
  Partials          ?        0           
Impacted Files Coverage Δ
...ponents/gallery/submit/market-application.model.ts 94.44% <0.00%> (ø)
src/@batch-flask/ui/card/card.component.ts 100.00% <0.00%> (ø)
...ter/result-picker-control/result-picker-control.ts 27.77% <0.00%> (ø)
src/app/models/dtos/task-container-settings.dto.ts 100.00% <0.00%> (ø)
...er-specific-data-store/user-specific-data-store.ts 76.62% <0.00%> (ø)
...atch-flask/ui/abstract-list/list-data-presenter.ts 86.84% <0.00%> (ø)
...tch/batch-application/batch-application.service.ts 59.09% <0.00%> (ø)
src/app/models/ms-graph/service-principal.ts 85.71% <0.00%> (ø)
src/app/decorators/pool-decorator.ts 84.61% <0.00%> (ø)
...le/action/add/patch-job-schedule-form.component.ts 25.00% <0.00%> (ø)
... and 889 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197793d...b093dd8. Read the comment docs.

@cRui861
Copy link
Contributor

cRui861 commented May 21, 2020

@bgklein @cRui861 either of you know what's going on with that build failure? Looks like a permissions issue.

Yeah its a permissions issue since he hasn't been added to the Github team yet. Asking for approval right now.

@cRui861
Copy link
Contributor

cRui861 commented May 21, 2020

@bgklein @cRui861 either of you know what's going on with that build failure? Looks like a permissions issue.

Yeah its a permissions issue since he hasn't been added to the Github team yet. Asking for approval right now.

Approved.

@dpwatrous dpwatrous self-assigned this May 29, 2020
@dpwatrous
Copy link
Contributor

This will be rolled in with the larger dependency update PR

@dpwatrous dpwatrous closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants