-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cosmos DB container and pkg/database client for PlatformWorkloadIdentityRoleSets #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s database client
kimorris27
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
May 15, 2024 19:31
cadenmarchese
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
slawande2
approved these changes
May 20, 2024
/azp run ci,e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
rajdeepc2792
approved these changes
May 22, 2024
anshulvermapatel
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-6448
This is the first of two PRs for this ticket. The API endpoints will come in a separate PR.
What this PR does / why we need it:
This PR adds a new Cosmos DB container for storing information about OCP operator managed identities and permissions and a database client for the RP to use to interact with that container.
Test plan for issue:
I deployed a full service RP and wrote a script that I ran locally to test all of the functionality of the database client. I could test in INT as well if we feel that it's necessary, but IMO we might as well wait until https://issues.redhat.com/browse/ARO-6449 is ready to be tested in INT to save a bit of time.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
The functionality of this database client will be validated as part of testing for https://issues.redhat.com/browse/ARO-6449 - see comments in "Test plan for issue" section.
How to test (requires a full service dev RP)
First, grant the shared dev RP service principal some additional permissions to allow it to authenticate to Key Vault and Cosmos DB. These steps assume that you have your own full service RP running, you deployed it using the contents of this PR branch, and you have sourced your
env-int
file.Once you've created the Key Vault access policy and the Document DB Account Contributor role assignment, you can put this script in your RP's root directory and run it with
go run <filepath>
: