update SDK to track2 in UpdateAPIIPEarly #3579
Merged
+311
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
changed the title
bitoku
force-pushed
the
updateAPIIPEarly-track2
branch
from
268c7d9
to
91c8b15
Compare
|
Please rebase pull request. |
bitoku
force-pushed
the
updateAPIIPEarly-track2
branch
from
91c8b15
to
7bef6bd
Compare
bitoku
force-pushed
the
updateAPIIPEarly-track2
branch
from
7bef6bd
to
6257519
Compare
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
bitoku
changed the title
bitoku
force-pushed
the
updateAPIIPEarly-track2
branch
from
6257519
to
a909b39
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
bitoku
force-pushed
the
updateAPIIPEarly-track2
branch
from
a909b39
to
729a019
Compare
bitoku
force-pushed
the
updateAPIIPEarly-track2
branch
from
729a019
to
3924fdc
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
AldoFusterTurpin
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM! Thank you @bitoku for the clarifications and applying the optional suggestions. Great work! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes a part of https://issues.redhat.com/browse/ARO-4665 and https://issues.redhat.com/browse/ARO-7316
What this PR does / why we need it:
It contains three changes.
PublicIPAddressestrack2 SDK.updateAPIIPEarlyuse track2 SDK.retryOptionto track2 SDKs.For
retryOptionsee https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azcore@v1.11.1/policy#RetryOptions and https://learn.microsoft.com/en-us/azure/developer/go/azure-sdk-core-concepts#http-pipeline-flowThe reason for creating new methods instead of modifying the current ones is to make the impact of each change as small as possible.
Test plan for issue:
unittest for updateAPIIPEarly.
test cluster installation in local.
e2e
Is there any documentation that needs to be updated for this PR?
tech debt cleanup N/A
How do you know this will function as expected in production?
cluster installation test