Allow customers to annotate CloudCredential resource on update #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
added
work-in-progress
chainsaw
- Initialize the operatorcli in both the real code and the unit tests - Compare the actual annotations on the CloudCredentials to the wantAnnotations
allow existing cc annotations, more test cases
cadenmarchese
force-pushed
the
cadenmarchese/ARO-7348/upgrade-annotations
branch
from
7b71ea5
to
fcca98c
Compare
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
requested changes
May 24, 2024
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
requested changes
May 31, 2024
rajdeepc2792
approved these changes
Jun 3, 2024
kimorris27
approved these changes
Jun 3, 2024
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hlipsig
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-7348
What this PR does / why we need it:
Clusters with manual credentials mode need to be annotated in order to be upgraded: https://docs.openshift.com/container-platform/4.14/updating/preparing_for_updates/preparing-manual-creds-update.html#cco-manual-upgrade-annotation_preparing-manual-creds-update
This PR adds a new API field that the user can patch on update, which will then annotate the cluster itself with the version.
Requires #3563 as this will also require some validation to ensure that the user is passing in a version and not some other string.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?