[DNM] Release 254 Analysis #3566
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make env know what the service component its running is * regen mocks
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* api: Avoid referencing DefaultInstallStream in tests * frontend: Avoid referencing DefaultInstallStream The frontend's OpenShiftVersions change feed handler will record the current default version for the rest of the frontend to use. * monitor: Remove latestGaMinorVersion metric The RP no longer has this information internally, so the metric is no longer relevant. * update_ocp_versions: Read versions from an environment variable Read OpenShift versions and pull specs from an OPENSHIFT_VERSIONS environment variable containing a JSON object. This data includes the default OpenShift version for new installs that don't specify a version. This moves us toward eliminating hard-coded OpenShift versions in pkg/util/version/const.go. * cache_fallback_discovery_client_test.go: Hard-code version I'm not sure what to do with this test. Install stream data has moved to RP-Config, so if the test is worth keeping then I guess the oldest supported version will have to be hard-coded and kept up-to-date. But it probably won't be. * version: Remove DefaultInstallStreams DefaultInstallStream will remain for now, but it's ONLY for use by local development mode until we can come up with a better solution. --------- Co-authored-by: Matthew Barnes <mbarnes@fedorapeople.org>
* adding 2023-11-22 stable --------- Co-authored-by: b-jhoreman <b-jhoreman@microsoft.com>
This is to give a heads up that this podman issue can occur if the podman user socket is not enabled.
Add permissions stanza to yamllint GH action
…rom it have the potential to be built with inconsistent Golang versions.
* Update the hack script to require the new envs * Add new targets to the Makefile * Update the docs * Fix typo * Add some info to the delete flow * Update docs/shared-cluster.md Co-authored-by: Jason Healy <jason@jhealy.net> * Tag all created resource groups with persist * Drop shared-cluster from the explicit denys * Update docs --------- Co-authored-by: Jason Healy <jason@jhealy.net>
…oller is invalid rather than panic (#3371)
* Wrap Delete call in Eventually to hopefully prevent flakes where Service deletion fails * Simplify logic and properly handle the case where the Service is not found during the delete call * After deleting the Service, confirm that it's gone
* Use another method of FIPS validation (fips-detect)
… required by k8s v1.27.x
* Added FP Check for validation * Cloud Err to surface level backend for SP issue
HiveNamespace currently uses aro-<uuid>, this change is an effort to unify UUIDs accross cluster doc instead of having multiple, by pointing HiveNamespace to docID so this can be leveraged later. More Details: https://redhat-internal.slack.com/archives/C02ULBRS68M/p1686806655273309
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.6 to 1.1.12. - [Release notes](https://github.com/opencontainers/runc/releases) - [Changelog](https://github.com/opencontainers/runc/blob/v1.1.12/CHANGELOG.md) - [Commits](opencontainers/runc@v1.1.6...v1.1.12) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Allow metricalerts, actiongroups, and activitylogalerts for monitoring in the denyassignment
The link was not pointing to where it was supposed to point. Corrected it.
… type (#3522) * Add new internal types * Add document types * Add new external API types * Add external API converter and example * Add new admin API types * Add admin API converter and static validator * Added ServiceAccounts to admin API static validator
We have set the char limit to 20 in our deployment template. Hence this env's value should also be atmost 20 char. It exceeds with a region with big name is chosed like australiaeast
* create client and vendor for armkeyvault * fix cluster * remove old keyvault * change input option to environment option * add credit * fix mix import * fix lint * fix import in valut * reoreder valut impoty * fix vulnerability * remobe package lock * fix audit * audit force * fix audit * ufix audit * run npm update then fix * fix nit * bump version * bump version * bump * bump * match with master * remove * lint * remove package-lock.json * change to arm option * mod vendor * fix lint * fix lint --------- Co-authored-by: jonachang <jonachang@microsoft.com>
* Do not perform explicit cluster deletion in prod e2e * Add more robust logging to deletion process * Refactor pkg/util/cluster Delete function to declaratively define deletion steps
Update some clienthelper hooks for better testing
Limit KEYVAULT_PREFIX to 20 Chars for INT deployment example
Drop ErrorIfNoField
* setting TLS1.2 as min for cosmoDB * nitpick * fixing marshalling
…rmissions for validations (#3524) * use checkAccessv2 for all permission validations * remove permission client dependency * dev fpsp requires authorization action permission for checkAccessv2
…24-08-12-preview APIs (#3538) * add read only fields to ExternalNoReady * run ExternalNoReadOnly on put or patch * clear readonly fields in 2024-08-12-preview
…loyment add dependsOn for cosmosdb container deployment templates
…etion-roleassignment-cleanup Do not perform explicit CSP roleassignment deletion in prod e2e
|
Please rebase pull request. |
|
can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy PR to help examine the diff between the v20240503.00 release and the last successful hotfix