-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dev-proxy-vmss to Azure Linux and enable rolling OS update #3562
Conversation
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle I think this makes sense but I have some questions:
- What do we do in prod and why do we need a dev-proxy?
- Should docs be updated as part of this?
- As far as I can make out, this code is used in quite a narrow set of places and I'm not even sure we use those any more. Possibly this can all be gutted?
@mociarain Here's it's purpose, from the ARO Wiki. Shared environment for local RP development
I agree, more documentation on this VMSS would be nice. |
@mociarain production is not needed as this is used in dev/INT only. dev-proxy-vmss can't be gutted yet mainly because it's still being used by non-prod environments, especially CI-e2e. to be honest, I'm not an expert about this component myself.... not sure if I'm the right person to write the doc for it. Can we track doc improvement in a separate ticket instead? |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as E2E passes 👍🏻
@nwnt @mociarain , I think the proxy VMSS is sufficiently covered in documentation already. See here: https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/166757/Debug-E2E I also added a link to this "Debug-E2E" page on the one that @s-fairchild linked to. |
I'm still just waiting for CI to report successful. It's okay to merge whenever that happens. |
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Which issue this PR addresses:
Fixes: ARO-7329
What this PR does / why we need it:
Security Sprint/Waves requires that 1p apps start using Azure Linux as its base OS and enable VMSS auto image upgrade.
To enable VMSS rolling upgrades, we need an LB with a healthcheck. Dev proxy doesn't have a healthcheck endpoint so I added a simple one on port 8080.
Test plan for issue:
Ensure the deployment is done and e2e runs successfully in INT. The changes will not be applied to Prod.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
N/A