Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dev-proxy-vmss to Azure Linux and enable rolling OS update #3562

Merged
merged 3 commits into from
May 22, 2024

Conversation

nwnt
Copy link
Contributor

@nwnt nwnt commented May 6, 2024

Which issue this PR addresses:

Fixes: ARO-7329

What this PR does / why we need it:

Security Sprint/Waves requires that 1p apps start using Azure Linux as its base OS and enable VMSS auto image upgrade.

To enable VMSS rolling upgrades, we need an LB with a healthcheck. Dev proxy doesn't have a healthcheck endpoint so I added a simple one on port 8080.

Test plan for issue:

Ensure the deployment is done and e2e runs successfully in INT. The changes will not be applied to Prod.

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

N/A

@nwnt
Copy link
Contributor Author

nwnt commented May 6, 2024

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot May 6, 2024
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle I think this makes sense but I have some questions:

  • What do we do in prod and why do we need a dev-proxy?
  • Should docs be updated as part of this?
  • As far as I can make out, this code is used in quite a narrow set of places and I'm not even sure we use those any more. Possibly this can all be gutted?

@s-fairchild
Copy link
Collaborator

In principle I think this makes sense but I have some questions:

* What do we do in prod and why do we need a dev-proxy?

* Should docs be updated as part of this?

* As far as I can make out this code is in a quite narrow set of places and I'm not even sure we use those anymore. Possibly this can all be gutted?

@mociarain Here's it's purpose, from the ARO Wiki. Shared environment for local RP development

dev-proxy-vmss - This is needed as a proxy for your local PR to access the k8s control plane endpoints while the cluster is being provisioned.

I agree, more documentation on this VMSS would be nice.

@nwnt
Copy link
Contributor Author

nwnt commented May 8, 2024

@mociarain production is not needed as this is used in dev/INT only. dev-proxy-vmss can't be gutted yet mainly because it's still being used by non-prod environments, especially CI-e2e.

to be honest, I'm not an expert about this component myself.... not sure if I'm the right person to write the doc for it. Can we track doc improvement in a separate ticket instead?

@hlipsig
Copy link
Contributor

hlipsig commented May 15, 2024

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as E2E passes 👍🏻

@kimorris27
Copy link
Contributor

@nwnt @mociarain , I think the proxy VMSS is sufficiently covered in documentation already. See here: https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/166757/Debug-E2E

I also added a link to this "Debug-E2E" page on the one that @s-fairchild linked to.

@hlipsig
Copy link
Contributor

hlipsig commented May 16, 2024

I'm still just waiting for CI to report successful. It's okay to merge whenever that happens.

@hlipsig
Copy link
Contributor

hlipsig commented May 16, 2024

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hlipsig hlipsig merged commit 191526c into master May 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants