Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to using Viper instead of env vars #3545

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented Apr 29, 2024

Which issue this PR addresses:

split out of other work

What this PR does / why we need it:

Ports ARO-RP to using Viper for configuration management, for that 12-factor goodness, and hopefully easier testing.

Test plan for issue:

Should be unit test/E2E covered

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

N/A

@hawkowl
Copy link
Collaborator Author

hawkowl commented Apr 29, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hawkowl
Copy link
Collaborator Author

hawkowl commented Apr 29, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hawkowl
Copy link
Collaborator Author

hawkowl commented Apr 29, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hawkowl
Copy link
Collaborator Author

hawkowl commented Apr 29, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hawkowl
Copy link
Collaborator Author

hawkowl commented Apr 29, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the needs-rebase branch needs a rebase label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Please rebase pull request.

@github-actions github-actions bot removed the needs-rebase branch needs a rebase label May 6, 2024
@hawkowl
Copy link
Collaborator Author

hawkowl commented May 6, 2024

/azp run e2e, ci

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase branch needs a rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant