-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc on rotating full RP env VPN certs #3544
Open
cadenmarchese
wants to merge
2
commits into
master
Choose a base branch
from
cadenmarchese/ARO-0000/add-vpn-document
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
April 26, 2024 13:41
cadenmarchese
added
documentation
Improvements or additions to documentation
ready-for-review
chainsaw
Pull requests or issues owned by Team Chainsaw
labels
Apr 26, 2024
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
cadenmarchese
force-pushed
the
cadenmarchese/ARO-0000/add-vpn-document
branch
from
May 2, 2024 13:14
e638dbd
to
ed6db90
Compare
/azp run ci,e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
mociarain
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced May 9, 2024
Merged
kimorris27
previously approved these changes
May 10, 2024
s-fairchild
previously approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small discrepancy, otherwise LGTM.
cadenmarchese
dismissed stale reviews from s-fairchild, kimorris27, and mociarain
via
May 21, 2024 20:27
7866d43
/azp run ci,e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chainsaw
Pull requests or issues owned by Team Chainsaw
documentation
Improvements or additions to documentation
ready-for-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
n/a
What this PR does / why we need it:
Adds doc on how to rotate certificates on a vnet gateway created as part of the full RP env setup. I've had to do it a few times so I figured it would be useful to document it upstream.
Test plan for issue:
n/a, docs issue.
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?