Make a package from pkg/api #3542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hawkowl
added
ready-for-review
go
|
This not needed for the direction of the installer project. The installer ARO wrapper is on the EOL path and using the RP API does not align with the archtecture being hashed out with the installer team. No longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3423
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-3571
What this PR does / why we need it:
This makes ARO-RP/pkg/api a golang package, similar to how Hive's API package is used. This means we can reuse the ARO-RP API definitions in other repos, such as the ARO-Installer-Wrapper repo.
Test plan for issue:
Unit tests should suffice
Is there any documentation that needs to be updated for this PR?
Not entirely sure -- the vendor check should catch if the vendoring doesn't occur after pkg/api changes.