Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guardrails): Update manifests to match 3.15.1 #3539

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jaitaiwan
Copy link
Contributor

@jaitaiwan jaitaiwan commented Apr 25, 2024

Which issue this PR addresses:

Current guardrails does not support go 1.20 which includes numerous critical security improvements.

Fixes ARO-6765

What this PR does / why we need it:

Updates guardrails to version 3.15.1 which is the latest version with go 1.20 support.

Test plan for issue:

Manual deployment of updated ARO Operator to test cluster, run tests as per guardrails existing test plan.

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

Updated operator will result in guardrails manifests being updated in customer's clusters.

Are there any prerequisites to this PR being merged?

  • Guardrails image mirrored to ACR
  • Test ARO Operator deployed to test cluster and manifests deploy automatically - results are as expected
  • Test existing policies work as expected (1 Policy, attempt to delete master node)

@mociarain
Copy link
Collaborator

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yjst2012
Copy link
Contributor

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yjst2012
Copy link
Contributor

yjst2012 commented May 7, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swiencki
Copy link
Collaborator

swiencki commented May 8, 2024

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants