-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(guardrails): Update manifests to match 3.15.1 #3539
Open
jaitaiwan
wants to merge
7
commits into
master
Choose a base branch
from
f/guardrails-3.15.1
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaitaiwan
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
April 25, 2024 23:53
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
mociarain
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Current guardrails does not support go 1.20 which includes numerous critical security improvements.
Fixes ARO-6765
What this PR does / why we need it:
Updates guardrails to version 3.15.1 which is the latest version with go 1.20 support.
Test plan for issue:
Manual deployment of updated ARO Operator to test cluster, run tests as per guardrails existing test plan.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Updated operator will result in guardrails manifests being updated in customer's clusters.
Are there any prerequisites to this PR being merged?