Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding owners for label #4149

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding owners for label #4149

wants to merge 4 commits into from

Conversation

aritraghosh
Copy link
Contributor

@aritraghosh aritraghosh commented Mar 7, 2024

Auto assign owners when labelled - Previously, owners were assigned only when the issue is opened with the label. Wit this change, the owners will get assigned when they get labelled (even when opened)
Removed the test label change - This was for testing some of the GH changes as there is no way to test this in private repos

@AllenWen-at-Azure
Copy link
Contributor

There are still rules with "assignMentionees: False", is that because the corresponding assignees are out of AKS team?

@@ -349,18 +349,28 @@ configuration:
- or:
- payloadType: Issues
- isAction:
action: Opened
action: Labeled
Copy link
Member

@Tatsinnit Tatsinnit May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡Observation share only: Worth to add context for this change of this lable please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍☕️ looks good to me. There is a merge conflict if you can please look into. Happy to merge post that is no one else has any feedback. I see this PR is open for a very long time. Thanks heaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants