Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axios versions #205

Closed
wants to merge 1 commit into from
Closed

Conversation

irembesik
Copy link

Purpose

Axios@0.18.0 has a bug which causes when request has Content-Encoding: gzip|deflate|compress header and response has 204 No Content status code the following error is thrown: HttpClientError: unexpected end of file.

Ref: axios/axios#1129

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Dependecy update

What to Check

Verify that the following are valid after npm install

  • axios package is at the version 0.19.0

Other Information

There is no breaking change of this dependency update
Ref: https://github.com/axios/axios/blob/master/CHANGELOG.md

this update has an important change 
axios/axios#1129
Copy link
Contributor

@ali92hm ali92hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramyapradhan
Copy link
Contributor

Hi @irembesik , thank you! This change was automatically in PR by GitHub security and has been merged. I will close this PR.
Thanks,
Ramya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants