Deadletter documentation added #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvonneCeelie
added
Type: Enhancement
Status: In Progress
Type: Feature
and removed
Type: Enhancement
labels
|
I think it needs to go to the 4.6.0 branch instead of master. |
added 2 commits
August 30, 2022 09:28
smcvb
previously requested changes
Sep 1, 2022
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
YvonneCeelie
commented
Sep 9, 2022
Strengthen point that the in-memory DLQ is not production ready #281
smcvb
dismissed
their stale review
Processed all comments myself. Hence I do not apply as a reviewer anymore.
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Co-authored-by: Mitchell Herrijgers <mitchellherrijgers@gmail.com>
Process review comments by adjusting and further fine-tuning description of: - the importance of sequencing dead letter, - where to find the SequencedDeadLetterProcessor, - the description of the message attribute, - the enqueue decision intro description, - a better example on diagnostics usage. #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Adjust DLQ intro section by: * adding a small introduction, * replacing event processor mentions for processing group, * add details on maintaining a dead letter sequence #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Adjust DLQ configuration section by: * adjusting the indentation, * slightly adjusting the samples, * replacing mentions of event processor with processing group #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Adjust DLQ processing section by: * expanding the intro section by explaining the SequencedDeadLetterProcessor and its methods, * adjust the sample titles * adjusting the indentation, * replacing repair for retry in the samples as there is no guarantee the letter is not enqueued again, * replacing mentions of event processor with processing group #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Adjust DLQ attributes section by: * fix the section title, * use code sections, * remove markTouched, withCause and withDiagnostics, * change message type to EventMessage * change cause type to Optional<Cause>, * explain why the cause may be empty, * explain that diagnostics are filled through an EnqueuePolicy #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Adjust DLQ policy section by: * introduce desire to not enqueue at all times, * introduce EnqueuePolicy and EnqueueDecision, * explain when the policy kicks in, * explain scenario when to configure a custom policy, * separate the policy creation and configuration into two sample sections * use several Decisions operations to showcase it. #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Adjust DLQ idempotency section by: * moving it to right after the intro section, * making it a separate subsection for clarity, * expanding on why this is strongly recommended #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Strengthen point that the in-memory DLQ is not production ready #281
smcvb
added a commit
that referenced
this pull request
Sep 13, 2022
Process review comments by adjusting and further fine-tuning description of: - the importance of sequencing dead letter, - where to find the SequencedDeadLetterProcessor, - the description of the message attribute, - the enqueue decision intro description, - a better example on diagnostics usage. #281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deadletter queue, see AxonFramework/AxonFramework#2021