Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Association values in a Saga #263

Merged
merged 2 commits into from
May 31, 2022
Merged

Association values in a Saga #263

merged 2 commits into from
May 31, 2022

Conversation

YvonneCeelie
Copy link
Contributor

@YvonneCeelie YvonneCeelie commented May 30, 2022 •
edited

Added the associatedValues() method of the SagaLifeCycle. See AxonFramework/AxonFramework#1125

@YvonneCeelie YvonneCeelie self-assigned this May 30, 2022
CodeDrivenMitch
CodeDrivenMitch approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YvonneCeelie YvonneCeelie added this to the Release 4.6.0 milestone May 30, 2022
smcvb
smcvb approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise, this looks good.

axon-framework/sagas/associations.md Outdated Show resolved Hide resolved
@smcvb
Update axon-framework/sagas/associations.md
8da3836 
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@YvonneCeelie YvonneCeelie merged commit 320c46e into master May 31, 2022
@YvonneCeelie YvonneCeelie deleted the association-values-saga branch May 31, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeDrivenMitch CodeDrivenMitch CodeDrivenMitch approved these changes

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs

Assignees

@YvonneCeelie YvonneCeelie

Labels
Priority 2: Should Status: Resolved Type: Feature
Projects
None yet
Milestone
Release 4.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YvonneCeelie @CodeDrivenMitch @smcvb