Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve heartbeat implementation structure and its logging #211

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Improve heartbeat implementation structure and its logging #211

merged 3 commits into from
Jul 11, 2022

Conversation

CodeDrivenMitch
Copy link
Contributor

Improves the HeartbeatMonitor structure and logging, making it easier to comprehend what's happening when they are malfunctioning.

@CodeDrivenMitch CodeDrivenMitch self-assigned this Jul 8, 2022
@smcvb smcvb added this to the Release 4.6.0 milestone Jul 8, 2022
abuijze
abuijze requested changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@abuijze abuijze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change suggestion (exception handling improvement)

src/main/java/io/axoniq/axonserver/connector/impl/HeartbeatMonitor.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@CodeDrivenMitch CodeDrivenMitch mentioned this pull request Jul 11, 2022
Closed
smcvb
smcvb approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@CodeDrivenMitch CodeDrivenMitch changed the base branch from master to connector-4.5.x July 11, 2022 09:09
@smcvb smcvb modified the milestones: Release 4.6.0, Release 4.5.6 Jul 11, 2022
@CodeDrivenMitch CodeDrivenMitch merged commit 38e4a17 into connector-4.5.x Jul 11, 2022
@CodeDrivenMitch CodeDrivenMitch deleted the feature/improved-heartbeat-logging branch July 11, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@saratry saratry Awaiting requested review from saratry

@abuijze abuijze Awaiting requested review from abuijze

Assignees

@CodeDrivenMitch CodeDrivenMitch

Labels
Priority 2: Should Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.5.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CodeDrivenMitch @abuijze @smcvb