Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for Streaming Query #280

Merged
merged 2 commits into from May 11, 2022
Merged

Adds support for Streaming Query #280

merged 2 commits into from May 11, 2022

Conversation

schananas
Copy link
Contributor

Solves #279

@schananas schananas self-assigned this May 10, 2022
@CLAassistant
Copy link

CLAassistant commented May 10, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@smcvb smcvb added this to the Release 4.6.0 milestone May 10, 2022
smcvb
smcvb requested changes May 10, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but the build fails at the moment. Might this have to do with differing Reactor versions between AF 4.6.0-SNAPSHOT and the Tracing extension?

@schananas schananas requested a review from smcvb May 11, 2022 14:42
@schananas
Copy link
Contributor Author

The changes look good to me, but the build fails at the moment. Might this have to do with differing Reactor versions between AF 4.6.0-SNAPSHOT and the Tracing extension?

Reactor dependency for test scope was missing, I checked the versions but they are same

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

smcvb
smcvb approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence I'm approving this pull request.

@smcvb smcvb merged commit 30af783 into master May 11, 2022
@smcvb smcvb deleted the feature/streaming-query branch May 11, 2022 14:52
@schananas schananas restored the feature/streaming-query branch July 4, 2022 12:49
@smcvb smcvb mentioned this pull request Sep 12, 2022
Closed
@smcvb smcvb deleted the feature/streaming-query branch September 12, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch

@YvonneCeelie YvonneCeelie Awaiting requested review from YvonneCeelie

Assignees

@schananas schananas

Labels
Priority 1: Must Status: Resolved Type: Feature
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schananas @CLAassistant @smcvb