Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar build in PRs #273

Merged
merged 1 commit into from Apr 20, 2022
Merged

Fix sonar build in PRs #273

merged 1 commit into from Apr 20, 2022

Conversation

CodeDrivenMitch
Copy link
Member

@CodeDrivenMitch CodeDrivenMitch commented Apr 20, 2022 •
edited

The sonar build was broken for PR's. This was due to whitespace. I removed it.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@CodeDrivenMitch CodeDrivenMitch changed the title Attempt to fix sonar build on 11 Fix sonar build in PRs Apr 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smcvb smcvb added this to the Release 4.6.0 milestone Apr 20, 2022
smcvb
smcvb approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to sign the CLA!

@CodeDrivenMitch CodeDrivenMitch merged commit ab713c0 into master Apr 20, 2022
@smcvb smcvb deleted the feature/fix-sonar branch April 21, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs

@YvonneCeelie YvonneCeelie Awaiting requested review from YvonneCeelie

Assignees

@CodeDrivenMitch CodeDrivenMitch

Labels
Priority 2: Should Status: Resolved Type: Bug
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CodeDrivenMitch @CLAassistant @smcvb