Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder extension to avoid passing java classes to repository builders #70

Merged
merged 1 commit into from Oct 15, 2020
Merged

Builder extension to avoid passing java classes to repository builders #70

merged 1 commit into from Oct 15, 2020

Conversation

zambrovski
Copy link
Collaborator

@zambrovski zambrovski commented Oct 14, 2020 •
edited

Fix #69

@zambrovski zambrovski changed the title another builder extension, fix #69 Builder extension to avoid passing java classes to repository builders Oct 14, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sandjelkovic sandjelkovic added this to the Release 0.2.0 milestone Oct 14, 2020
smcvb
smcvb approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

sandjelkovic
sandjelkovic approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@sandjelkovic sandjelkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sandjelkovic sandjelkovic merged commit ab706a1 into AxonFramework:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@sandjelkovic sandjelkovic sandjelkovic approved these changes

Assignees

@zambrovski zambrovski

Labels
Priority 2: Should Status: Resolved Type: Feature
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.

Create builder extensions to avoid passing Foo::class.java
3 participants
@zambrovski @smcvb @sandjelkovic