Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/gha trigger #39

Merged
merged 3 commits into from Sep 25, 2020
Merged

Chore/gha trigger #39

merged 3 commits into from Sep 25, 2020

Conversation

zambrovski
Copy link
Collaborator

Fix #38

@smcvb smcvb added this to the Release 0.2.0 milestone Sep 22, 2020
@zambrovski
Copy link
Collaborator Author

zambrovski commented Sep 22, 2020 •
edited

Since @smcvb merged the changes of dependebot, there are some conflicts. I believe, this PR must wait until #37 is merged.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lfgcampos
lfgcampos approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@lfgcampos lfgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one.

sandjelkovic
sandjelkovic approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@sandjelkovic sandjelkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandjelkovic sandjelkovic merged commit efd2c51 into AxonFramework:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandjelkovic sandjelkovic sandjelkovic approved these changes

@lfgcampos lfgcampos lfgcampos approved these changes

@smcvb smcvb Awaiting requested review from smcvb

Assignees

@zambrovski zambrovski

Labels
Priority 2: Should Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.

Trigger GitHub Action build on pull request
4 participants
@zambrovski @sandjelkovic @lfgcampos @smcvb