Feature/10 gateway extension test #12

sandjelkovic · 2019-12-31T13:51:48Z

This PR will resolve #10

Added gateway tests.
Added Mockk as mocking library
Refactored visibility of Gateway extensions to allow them to be visible.
Created and extracted CombiningCommandCallback for easier testability

…ings

smcvb

Massive bunch of documentation arguments. Think those should be resolved prior to my approval. Conceptually, I do not see any issues with the provided code, hence I am not being harsh we a "request changes".

smcvb · 2020-01-02T09:48:34Z

kotlin/src/main/kotlin/org/axonframework/extensions/kotlin/CombiningCommandCallback.kt

+ * #%L
+ * Axon Framework - Kotlin Extension
+ * %%
+ * Copyright (C) 2019 AxonIQ
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ * #L%


Are the #, % and L characters intended in the copyright notice?

For now, I updated all of the headers manually.
The license headers with these characters were generated by the license-maven-plugin configured here and here

Created #14 to look into this in more detail.

smcvb · 2020-01-02T09:49:26Z

kotlin/src/main/kotlin/org/axonframework/extensions/kotlin/CombiningCommandCallback.kt

+import org.axonframework.messaging.MetaData
+
+/**
+ * Implementation of the [CommandCallback] that is appropriate for dedicated [onError] and [onSuccess] callbacks


Do we want to point out the authors of a class for this extension?

smcvb · 2020-01-02T09:50:20Z

kotlin/src/main/kotlin/org/axonframework/extensions/kotlin/CombiningCommandCallback.kt

+import org.axonframework.messaging.MetaData
+
+/**
+ * Implementation of the [CommandCallback] that is appropriate for dedicated [onError] and [onSuccess] callbacks


Do we have a milestone/version plan for this extension? Or, differently put, wouldn't a @since tag (or KotlinDocs equivalent) be in place?

Created #18 to handle this topic

kotlin/src/main/kotlin/org/axonframework/extensions/kotlin/CombiningCommandCallback.kt

smcvb · 2020-01-02T10:03:48Z

kotlin/src/main/kotlin/org/axonframework/extensions/kotlin/CommandGatewayExtensions.kt

 import org.axonframework.commandhandling.CommandMessage
 import org.axonframework.commandhandling.gateway.CommandGateway
 import org.axonframework.messaging.MetaData
 import java.util.concurrent.TimeUnit

 /**
- * Extension for command gateway.
+ * Callback-style send with dedicated on-success and on-error functions (defaults do nothing)


This is still an extension function of the CommandGateway it's send(C, CommandCallback<? super C, ? super R>), right? I think the documentation should specify that, as well as linking to the original method's documentation with the bracket ([CommandGateway.send] notation.

kotlin/src/test/kotlin/org/axonframework/extensions/kotlin/QueryGatewayExtensionsTest.kt

smcvb · 2020-01-02T10:38:49Z

kotlin/src/test/kotlin/org/axonframework/extensions/kotlin/CombiningCommandCallbackTest.kt

+    private val exceptionalCommandResultMessage = GenericCommandResultMessage.asCommandResultMessage<String>(CommandDispatchException("Exception message"))
+    private val metaData = MetaData.with("key", "value")
+
+    @Test


Should've told you earlier (so sorry for this), but the framework has moved to JUnit 5 entirely at the moment and the majority of the Kafka Extension has been adjusted. Might be beneficial take this stance for the Kotlin extension too.

smcvb · 2020-01-02T10:40:33Z

kotlin/src/test/kotlin/org/axonframework/extensions/kotlin/QueryGatewayExtensionsTest.kt

+
+}
+
+private class ExampleQuery(val value: Number)


Super nit: shouldn't this be a data class too?

smcvb · 2020-01-02T10:40:54Z

kotlin/src/test/kotlin/org/axonframework/extensions/kotlin/mockkExtensions.kt

+/*-
+ * #%L
+ * Axon Framework - Kotlin Extension
+ * %%
+ * Copyright (C) 2019 AxonIQ
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ * #L%
+ */


Are the #, % and L characters intended in the copyright notice?

smcvb · 2020-01-02T10:41:14Z

kotlin/src/test/kotlin/org/axonframework/extensions/kotlin/mockkExtensions.kt

+import org.axonframework.messaging.responsetypes.ResponseType
+import java.util.*
+
+internal fun <T> MockKVerificationScope.responseTypeOfMatcher(clazz: Class<T>) = match { type: ResponseType<T> -> type.expectedResponseType == clazz }


I think these methods deserve some documentation.

smcvb

Looks good to me 👍

smcvb · 2020-01-22T08:57:43Z

kotlin/src/main/kotlin/org/axonframework/extensions/kotlin/CommandGatewayExtensions.kt

@@ -19,43 +19,28 @@
 */
 package org.axonframework.extensions.kotlin

-import org.axonframework.commandhandling.CommandCallback
 import org.axonframework.commandhandling.CommandMessage
 import org.axonframework.commandhandling.gateway.CommandGateway
 import org.axonframework.messaging.MetaData
 import java.util.concurrent.TimeUnit



I am trusting in your expertise here @sandjelkovic. Thus, removing it should be fine then.

sandjelkovic added 6 commits December 24, 2019 16:14

#10 Add tests for QueryGateway extensions

59ee2c6

#10 Add tests for CommandGateway extensions

8cd8d30

#10 Remove explicit unused arguments in lambdas, fixing compiler warn…

1c38f36

…ings

#10 Create dedicated CommandCallback

d110cc0

#10 Improve documentation links and cleanup

367429b

#10 Add licence headers

f016df3

sandjelkovic requested review from abuijze, jangalinski, snowe2010 and smcvb December 31, 2019 13:51

smcvb assigned sandjelkovic Jan 2, 2020

smcvb added Status: In Progress Type: Enhancement Priority 1: Must Priority 2: Should and removed Priority 1: Must labels Jan 2, 2020

smcvb reviewed Jan 2, 2020

View reviewed changes

sandjelkovic added 3 commits January 8, 2020 10:53

Expand documentation for Command Gateway and Query Gateway extensions

61757a0

Improve ExampleQuery and ExampleCommand

eee254e

Update licence headers

1cebb4b

sandjelkovic mentioned this pull request Jan 8, 2020

Maven license plugin is adding extra characters #14

Closed

sandjelkovic added 5 commits January 8, 2020 15:07

Add documentation to custom Mockk matchers

8befd67

Upgrade to JUnit 5

e6f77ef

Add Class level KDocs and author tags

d006f71

Rename CombiningCommandCallback to more appropriate name

2aab717

Extract Test objects to a separate file

0a8ec43

sandjelkovic requested a review from smcvb January 21, 2020 15:34

smcvb approved these changes Jan 22, 2020

View reviewed changes

snowe2010 approved these changes Jan 24, 2020

View reviewed changes

Remove extra Command Gateway extensions

972d7b0

sandjelkovic merged commit e2c67a7 into master Jan 29, 2020

sandjelkovic deleted the feature/10-gateway-extension-test branch August 7, 2020 09:12

smcvb added this to the Release 0.1.0 milestone Aug 12, 2020

smcvb added Status: Resolved and removed Status: In Progress labels Sep 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/10 gateway extension test #12

Feature/10 gateway extension test #12

sandjelkovic commented Dec 31, 2019

smcvb left a comment

smcvb Jan 2, 2020

sandjelkovic Jan 8, 2020

smcvb Jan 2, 2020

smcvb Jan 2, 2020

sandjelkovic Jan 21, 2020

smcvb Jan 2, 2020

smcvb Jan 2, 2020

smcvb Jan 2, 2020

smcvb Jan 2, 2020

smcvb Jan 2, 2020

smcvb left a comment

smcvb Jan 22, 2020

Feature/10 gateway extension test #12

Feature/10 gateway extension test #12

Conversation

sandjelkovic commented Dec 31, 2019

smcvb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smcvb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment