Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter Gather queries extensions #16

Closed
sandjelkovic opened this issue Jan 14, 2020 · 0 comments · Fixed by #76
Closed

Scatter Gather queries extensions #16

sandjelkovic opened this issue Jan 14, 2020 · 0 comments · Fixed by #76

Comments

@sandjelkovic
Copy link
Member

sandjelkovic commented Jan 14, 2020

To use Scatter-Gather queries, gateway methods require ResponseType objects to be used to indicate return types.

To make it Kotlin idiomatic, extension methods on QueryGateway should be implemented to use reified generics, provide a method per ResponseType (Single without a suffix/Optional/Multiple Many) and forward those calls to existing methods on the QueryGateway.

New methods should also use Kotlin.time Duration in their signatures and convert to appropriate value and time unit for QueryGateway method invocation. Time unit of TimeUnit.MILLISECONDS might be a good option.
Since Kotlin time is still experimental, this might not be a good idea for the time being. When it stabilizes, it might be worth to reconsider

Examples of these types of extensions created for the query method can be found here.

This issue is similar to #11, but for different methods and types of queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment