Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an AMQP sample to show how to use the extension #126

Merged
merged 4 commits into from Sep 20, 2021
Merged

Added an AMQP sample to show how to use the extension #126

merged 4 commits into from Sep 20, 2021

Conversation

lfgcampos
Copy link
Contributor

Closes #93 .

@lfgcampos lfgcampos self-assigned this Sep 15, 2021
@smcvb smcvb added this to the Release 4.6.0 milestone Sep 16, 2021
smcvb
smcvb reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of minor comments.

amqp-axon-example/README.md Outdated Show resolved Hide resolved
amqp-axon-example/README.md Outdated Show resolved Hide resolved
amqp-axon-example/pom.xml Show resolved Hide resolved
amqp-axon-example/pom.xml Outdated Show resolved Hide resolved
amqp-axon-example/rabbit_enabled_plugins Outdated Show resolved Hide resolved
amqp-axon-example/pom.xml Show resolved Hide resolved
...ample/src/main/kotlin/org/axonframework/extension/amqp/example/AMQPAxonExampleApplication.kt Outdated Show resolved Hide resolved
amqp-axon-example/src/main/kotlin/org/axonframework/extension/amqp/example/client/BankClient.kt Show resolved Hide resolved
copyright-template.xml Outdated Show resolved Hide resolved
@corradom
Copy link
Contributor

I'm still in doubt if we should call
SAMPLE
over
EXAMPLE

I remember that we took a decision for of https://github.com/AxonIQ/code-samples ... maybe we should be consistent in naming.

lfgcampos and others added 2 commits September 17, 2021 14:12
@lfgcampos @smcvb @corradom
Apply suggestions from code review
ff6131c 
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Corrado Musumeci <corradom@gmail.com>
@lfgcampos
Apply suggestions from code review
72d5e1e
smcvb
smcvb reviewed Sep 17, 2021
View reviewed changes
amqp-axon-example/README.md Outdated Show resolved Hide resolved
smcvb
smcvb approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence approving.

@lfgcampos @smcvb
Update amqp-axon-example/README.md
1b2749d 
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lfgcampos lfgcampos merged commit c40d22b into master Sep 20, 2021
@corradom corradom deleted the add-sample branch September 21, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corradom corradom corradom approved these changes

@smcvb smcvb smcvb approved these changes

Assignees

@lfgcampos lfgcampos

Labels
Priority 2: Should Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

Introduce an axon-example
3 participants
@lfgcampos @corradom @smcvb