Ensure default TrackingEventProcessorConfiguration is taken into account for Sagas
#2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a default TrackingEventProcessorConfiguration was configured consciously through the EventProcessingConfigurer, it was not taken into accounts for Sagas. This occurs as the EventProcessingModule does not validate whether a default TEP was configured to switch between customization and the default Saga TEP configuration. #bug/default-tep-config-sagas
smcvb
added
Type: Bug
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
Remove redundant import #2533
|
Kudos, SonarCloud Quality Gate passed! |
saratry
approved these changes
Dec 29, 2022
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EventProcessingConfigurer#registerTrackingEventProcessorConfiguration(Function<Configuration, TrackingEventProcessorConfiguration>)did not overrule the default SagaTrackingEventProcessorConfiguration.This is an unintended side effect when we introduced the default configuration for Sagas in issue #1019.
This pull request resolves that by adding the default
TrackingEventProcessorConfigurationin the map ofTrackingEventProcessorConfigurationswhenEventProcessingConfigurer#registerTrackingEventProcessorConfigurationis invoked.This provides a simple location to validate this customization when constructing the
TrackingEventProcessorand when defining the Saga configuration.