Proposed changes to caching saga fix #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing concurrency on the CachingSagaStore
…ization on the associations cache
… the delegate in a synchronised set to prevent concurrency issues leading to a ConcurrentModificationException in some cases.
… check whether value is still not garbage collected or cleaned
smcvb
added
Type: Enhancement
smcvb
requested review from
a team,
gklijs and
smcvb
and removed request for
a team
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current fix can still trigger the ConcurrentModificationException.
This PR contains a testcase that will reliably create an exception by using the CachingSagaStore directly without modelling intervention. It does so by ending/creating saga's and querying saga's from multiple threads, causing the exception.
It also contains a fix which should be discussed. It introduces locking on the associationsCache.