Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel of direct query #2528

Merged
merged 2 commits into from Dec 29, 2022
Merged

Cancel of direct query #2528

merged 2 commits into from Dec 29, 2022

Conversation

saratry
Copy link
Contributor

@saratry saratry commented Dec 22, 2022

The canceling of the completable future result of a direct query should cause the canceling of the query to be propagated to AxonServer too.

@saratry
The cancelling of the completable future result of a direct query sho…
105073b 
…uld cause the cancelling of the query to be propagated to AxonServer too.
@saratry saratry self-assigned this Dec 22, 2022
@smcvb smcvb added Type: Bug Use to signal issues that describe a bug within the system. Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: In Progress Use to signal this issue is actively worked on. labels Dec 23, 2022
@smcvb smcvb added this to the Release 4.6.3 milestone Dec 23, 2022
smcvb
smcvb approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@saratry
The cancelling of the completable future result of a direct query sho…
de5f125 
…uld cause the cancelling of the query to be propagated to the QueryBus too.
smcvb
smcvb approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think this looks fine.

@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@smcvb smcvb merged commit 0881004 into axon-4.6.x Dec 29, 2022
@smcvb smcvb deleted the bug/cancel-axon-server-query branch December 29, 2022 16:21
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@vaishsriram vaishsriram Awaiting requested review from vaishsriram

@sandjelkovic sandjelkovic Awaiting requested review from sandjelkovic

@m1l4n54v1c m1l4n54v1c Awaiting requested review from m1l4n54v1c

Assignees

@saratry saratry

Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saratry @smcvb