[#2514] Fix naming of registered Repository and AggregateFactory beans
#2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix naming of Repository bean name, by using a lower cased initial letter for the aggregate type. Furthermore, fix this for the AggregateFactory bean too, as it adhered to the same adjusted, and faulty, naming behavior. #2514
smcvb
added
Type: Bug
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
Fine tune test case to clearly state the wrong bean name, by extracting all bean names for the Repository class. #2514
The AggregateStereotypeAutoConfigurationTest wrongfully expects the bean name to be the full @aggregate annotated class name for the Repository. Next to fixing this, resolves some warnings in this file while we're at it, like forcing the identifier to be an Object to *not* use the deprecated VersionedAggregateIdentifier constructor. #2514
|
SonarCloud Quality Gate failed. |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent switch to a newer Spring integration, the naming of the
RepositoryandAggregateFactorybeans.More specifically, the fully qualified class name of the
@Aggregateannotated class, combined with"Repository"and"AggregateFactory"was the bean.Instead, as in pre-AxonFramework-4.6, the name should be the simple name of the
@Aggregateannotated class, combined with"Repository"and"AggregateFactory"was the bean.This pull request rectifies this, by registering the
RepositoryandAggregateFactorybeans through the aforementioned naming scheme.Doing so, this pull request resolves #2514.