Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll back slf4j to major version 1 #2497

Closed
wants to merge 1 commit into from
Closed

Roll back slf4j to major version 1 #2497

wants to merge 1 commit into from

Conversation

CodeDrivenMitch
Copy link
Member

During 4.6 we upgraded slf4j-api to 2.x. However, in many situations, this does not work since Spring Boot still includes 1.x. This PR rolls back this change.

@CodeDrivenMitch CodeDrivenMitch added Type: Bug Use to signal issues that describe a bug within the system. Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. labels Nov 18, 2022
@CodeDrivenMitch CodeDrivenMitch added this to the Release 4.6.3 milestone Nov 18, 2022
@CodeDrivenMitch CodeDrivenMitch requested a review from a team November 18, 2022 06:48
@CodeDrivenMitch CodeDrivenMitch self-assigned this Nov 18, 2022
@CodeDrivenMitch CodeDrivenMitch requested review from gklijs and smcvb and removed request for a team November 18, 2022 06:48
@smcvb smcvb added the Status: In Progress Use to signal this issue is actively worked on. label Nov 18, 2022
smcvb
smcvb approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine decision to roll this back, as it's causing more harm than good. You need to fix the build before merging, though.

@gklijs
Copy link
Contributor

gklijs commented Nov 18, 2022

See the commit of the update. I'm not convinced we should through.

This was referenced Nov 21, 2022
Closed
Closed
@smcvb smcvb deleted the fix/slf4j-version branch November 28, 2022 16:55
@smcvb smcvb added Status: Won't Fix Use to signal that the issue is acknowledged, but it’s decided that the work will not be performed. and removed Status: In Progress Use to signal this issue is actively worked on. labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs gklijs was automatically assigned from AxonFramework/framework-developers

Assignees

@CodeDrivenMitch CodeDrivenMitch

Labels
Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: Won't Fix Use to signal that the issue is acknowledged, but it’s decided that the work will not be performed. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CodeDrivenMitch @gklijs @smcvb