Allow usage of specific serializers for the JpaDLQ #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeDrivenMitch
added
Type: Enhancement
CodeDrivenMitch
requested review from
gklijs and
smcvb
and removed request for
a team
smcvb
added
the
Status: In Progress
smcvb
approved these changes
Nov 15, 2022
...ing/src/main/java/org/axonframework/eventhandling/deadletter/jpa/DeadLetterJpaConverter.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/org/axonframework/eventhandling/deadletter/jpa/DeadLetterJpaConverter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
CodeDrivenMitch
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, differentiation is wanted when serializing a dead letter to the database. This PR allows users to configure an event serializer, and a generic serializer.
The event serializer is used for serialization of the event payload, event metadata, and diagnostics of the Dead letter.
The generic serialize is used for the serialization of the tracking token.
The builder still has the
serializer()method and I have decided not to deprecate it. In a lot of cases, setting one serializer for both types is enough.Closing #2485