[#2481] Check MessageHandlerRegistrar registration to be non-null
#2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the registration is non-null before invoking shutdown, as this may cause a NullPointerException. If it is null, log an info level message stating this situation. #2481
smcvb
added
Type: Bug
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
Remove undesired test case #2481
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MessageHandlerRegistrar#shutdownoperation might cause aNullPointerExceptionif it wasn't started yet.Although the chances of this are slim, it does cause noise in the shutdown procedure of a
Configuration.As such, we should check whether the
handlerRegistrationis not null before invoking it.If it's null, we can log the fact it was never started to begin with.
By doing so, we resolve #2481.