Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Slack release announcement #2348

Merged
merged 1 commit into from Sep 7, 2022
Merged

Added Slack release announcement #2348

merged 1 commit into from Sep 7, 2022

Conversation

YvonneCeelie
Copy link
Contributor

Some customers would like to get an announcement on Slack when a new version has been released.
To make this work a Github secret (secrets.SLACK_WEBHOOK) needs to be added.

@YvonneCeelie YvonneCeelie self-assigned this Sep 6, 2022
gklijs
gklijs approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb added Type: Feature Use to signal an issue is completely new to the project. Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. labels Sep 7, 2022
@smcvb smcvb added this to the Release 4.6.0 milestone Sep 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.5% 91.5% Coverage
0.0% 0.0% Duplication

smcvb
smcvb approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust in your judgment that this change is valid.

@smcvb smcvb merged commit 91b9751 into master Sep 7, 2022
@smcvb smcvb deleted the slack-release-annoucement branch September 7, 2022 12:41
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gklijs gklijs gklijs approved these changes

@smcvb smcvb smcvb approved these changes

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch

Assignees

@YvonneCeelie YvonneCeelie

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YvonneCeelie @gklijs @smcvb