Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the concurrent behaviour of the tracking event processor. #2311

Merged
merged 1 commit into from Jul 29, 2022

Conversation

gklijs
Copy link
Member

@gklijs gklijs commented Jul 29, 2022

Turns out there were a few edge cases left. I also restructured a bit, to make both workers more the same. Now when a worker 'switches jobs' it will always be from the cleanup/finally.

The main left over problem was that the AtomicBoolean for the workLauncherRunning was set from the worker thread. So it could happen that it would switch to true, after calling start(), which in turn prevented the thread to be stopped at shutdown() which in turn caused an error when calling start() again, since it was not properly shutdown, as expected.

Additionally a removeThread(String name) method was added, where the expectation is that it will never actually log the message, but would provide valuable information if it does.

This was locally tested as fix for #2293, 10.000 times stopping and starting worked without problems, where the latest release would give an error around 30-50 times.

@gklijs gklijs added Type: Bug Use to signal issues that describe a bug within the system. Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: In Progress Use to signal this issue is actively worked on. labels Jul 29, 2022
@gklijs gklijs added this to the Release 4.5.15 milestone Jul 29, 2022
@gklijs gklijs self-assigned this Jul 29, 2022
@gklijs gklijs requested a review from smcvb July 29, 2022 12:49
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit c783ce6 into axon-4.5.x Jul 29, 2022
@smcvb smcvb deleted the bug/2293 branch July 29, 2022 16:24
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants