[#2290] TrackingEventProcessor does not wait for his worker threads to shut down
#2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker threads to shut down Signed-off-by: Nils Christian Ehmke <nils-christian.ehmke@bmiag.de>
OLibutzki
reviewed
Jul 15, 2022
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
…ker threads to shut down Signed-off-by: Nils Christian Ehmke <nils-christian.ehmke@bmiag.de>
smcvb
added
Priority 4: Would
smcvb
changed the title
TrackingEventProcessor does not wait for his worker threads to shut down
smcvb
requested changes
Jul 19, 2022
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
…ngEventProcessor.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
smcvb
reviewed
Jul 20, 2022
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
smcvb
reviewed
Jul 20, 2022
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
|
Provided the commit suggestions just now, @nils-christian. Might be fair if we provide a style guide for Eclipse somewhere in the future too 😅 |
…ngEventProcessor.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…ngEventProcessor.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
|
Suggestions applied. Thank you @smcvb. |
smcvb
approved these changes
Jul 20, 2022
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrackingEventProcessor does not wait for his worker threads to shut down
Signed-off-by: Nils Christian Ehmke nils-christian.ehmke@bmiag.de
This pull request resolves #2290.